Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Konnect curl request in renew-certificates.md #6510

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

gforns
Copy link
Contributor

@gforns gforns commented Nov 14, 2023

Description

Modified curl example for Konnect:

Testing instructions

Preview link:

Checklist

  • Review label added
  • PR pointed to correct branch (main for immediate publishing, or a release branch: e.g. release/gateway-3.2, release/deck-1.17)

- needed to add double-quotes to properly expand $CERT envvar (curl was giving an error)
- Included the Authorization header in the Konnect request
@gforns gforns requested a review from a team as a code owner November 14, 2023 18:02
Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit fe7258b
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/6553b62e46b206000879f3bd
😎 Deploy Preview https://deploy-preview-6510--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 91 (no change from production)
Accessibility: 80 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@gforns gforns added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Nov 15, 2023
Copy link
Contributor

@Guaris Guaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Guaris Guaris merged commit c778186 into main Nov 17, 2023
21 of 23 checks passed
@Guaris Guaris deleted the gforns-patch-1 branch November 17, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants