Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect to KIC in Konnect on cloud install pages #6517

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Redirect to KIC in Konnect on cloud install pages #6517

merged 1 commit into from
Nov 15, 2023

Conversation

mheap
Copy link
Member

@mheap mheap commented Nov 15, 2023

Description

Make it clear that KIC install instructions are not for Konnect + redirect to Gateway Manager as needed

Testing instructions

Preview link: /kubernetes-ingress-controller/latest/install/cloud/gke/

Checklist

  • Review label added
  • PR pointed to correct branch (main for immediate publishing, or a release branch: e.g. release/gateway-3.2, release/deck-1.17)

@mheap mheap added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Nov 15, 2023
@mheap mheap requested a review from a team as a code owner November 15, 2023 14:40
@netlify Netlify
Copy link

netlify bot commented Nov 15, 2023 •
edited
Loading

✅ Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit ac96557
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/6554d86a3b956600082d4f30
😎 Deploy Preview https://deploy-preview-6517--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 9 paths audited
Performance: 91 (🟢 up 1 from production)
Accessibility: 80 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 89 (🔴 down 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

acgoldsmith
acgoldsmith approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@acgoldsmith acgoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mheap mheap merged commit a006e62 into main Nov 15, 2023
21 of 22 checks passed
@mheap mheap deleted the kic-konnect-redirect branch November 15, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acgoldsmith acgoldsmith acgoldsmith approved these changes

Assignees
No one assigned
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mheap @acgoldsmith @Guaris