-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kgo: document KongPluginInstallation #8034
Open
programmer04
wants to merge
8
commits into
main
Choose a base branch
from
plugin-dist
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+3,854
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programmer04
added
team-k8s
Kubernetes task tracking (including KIC,KGO)
area/docs
labels
Oct 9, 2024
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
programmer04
added
the
review:sme
Request for SME review, external to the docs team.
label
Oct 9, 2024
programmer04
force-pushed
the
plugin-dist
branch
3 times, most recently
from
October 9, 2024 14:41
5d22117
to
72ac3c1
Compare
pmalek
reviewed
Oct 9, 2024
2 tasks
programmer04
force-pushed
the
plugin-dist
branch
3 times, most recently
from
October 9, 2024 21:03
6a771a8
to
f2d813a
Compare
programmer04
force-pushed
the
plugin-dist
branch
3 times, most recently
from
October 10, 2024 12:10
8a0b8f0
to
ae61210
Compare
pmalek
reviewed
Oct 10, 2024
@pmalek Ready for the second round and manual test, I've simplified YAMLs a little bit too |
pmalek
reviewed
Oct 10, 2024
pmalek
reviewed
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've followed this tutorial using a dev build locally and this worked flawlessly for me 🎉
pmalek
approved these changes
Oct 10, 2024
programmer04
force-pushed
the
plugin-dist
branch
from
October 10, 2024 16:15
87cc3b1
to
7cd32de
Compare
pmalek
approved these changes
Oct 11, 2024
Co-authored-by: Patryk Małek <[email protected]>
Co-authored-by: Patryk Małek <[email protected]>
Co-authored-by: Patryk Małek <[email protected]>
programmer04
force-pushed
the
plugin-dist
branch
from
October 11, 2024 09:36
7cd32de
to
834117f
Compare
programmer04
added
the
review:general
Review for general accuracy and presentation. Does the doc work? Does it output correctly?
label
Oct 11, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/docs
review:general
Review for general accuracy and presentation. Does the doc work? Does it output correctly?
review:sme
Request for SME review, external to the docs team.
team-k8s
Kubernetes task tracking (including KIC,KGO)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes
Testing instructions
The most important page of this PR - https://deploy-preview-8034--kongdocs.netlify.app/gateway-operator/unreleased/guides/plugin-distribution/
The page touched by this PR - https://deploy-preview-8034--kongdocs.netlify.app/kubernetes-ingress-controller/latest/plugins/custom/
Checklist