Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kgo: document KongPluginInstallation #8034

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

kgo: document KongPluginInstallation #8034

wants to merge 8 commits into from
+3,854 −67

Conversation

programmer04
Copy link
Member

@programmer04 programmer04 commented Oct 9, 2024 •
edited
Loading

@programmer04 programmer04 added team-k8s Kubernetes task tracking (including KIC,KGO) area/docs labels Oct 9, 2024
@programmer04 programmer04 added this to the KGO v1.4.x milestone Oct 9, 2024
@programmer04 programmer04 self-assigned this Oct 9, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 9, 2024 •
edited
Loading

✅ Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 834117f
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/6708f19bd1db86000852a32a
😎 Deploy Preview https://deploy-preview-8034--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 9 paths audited
Performance: 93 (🟢 up 3 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 90 (🔴 down 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@programmer04 programmer04 added the review:sme Request for SME review, external to the docs team. label Oct 9, 2024
@programmer04 programmer04 force-pushed the plugin-dist branch 3 times, most recently from 5d22117 to 72ac3c1 Compare October 9, 2024 14:41
@pmalek pmalek mentioned this pull request Oct 9, 2024
Open
2 tasks
@programmer04 programmer04 force-pushed the plugin-dist branch 3 times, most recently from 6a771a8 to f2d813a Compare October 9, 2024 21:03
@programmer04 programmer04 marked this pull request as ready for review October 9, 2024 21:06
@programmer04 programmer04 requested a review from a team as a code owner October 9, 2024 21:06
@programmer04 programmer04 force-pushed the plugin-dist branch 3 times, most recently from 8a0b8f0 to ae61210 Compare October 10, 2024 12:10
pmalek
pmalek reviewed Oct 10, 2024
View reviewed changes
app/_includes/md/custom-plugin.md Outdated Show resolved Hide resolved
app/_includes/md/kgo/prerequisites.md Show resolved Hide resolved
app/_src/gateway-operator/guides/plugin-distribution.md Outdated Show resolved Hide resolved
app/_includes/md/custom-plugin.md Show resolved Hide resolved
app/_src/gateway-operator/guides/plugin-distribution.md Outdated Show resolved Hide resolved
app/_src/gateway-operator/guides/plugin-distribution.md Outdated Show resolved Hide resolved
app/_src/gateway-operator/guides/plugin-distribution.md Outdated Show resolved Hide resolved
app/_src/gateway-operator/guides/plugin-distribution.md Outdated Show resolved Hide resolved
app/_src/kubernetes-ingress-controller/plugins/custom.md Outdated Show resolved Hide resolved
@programmer04
Copy link
Member Author

@pmalek Ready for the second round and manual test, I've simplified YAMLs a little bit too

pmalek
pmalek reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've followed this tutorial using a dev build locally and this worked flawlessly for me 🎉

app/_src/gateway-operator/guides/plugin-distribution.md Show resolved Hide resolved
@programmer04 programmer04 added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Oct 11, 2024
@randmonkey randmonkey mentioned this pull request Oct 14, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmalek pmalek pmalek approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@programmer04 programmer04

Labels
area/docs review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? review:sme Request for SME review, external to the docs team. team-k8s Kubernetes task tracking (including KIC,KGO)
Projects
None yet
Milestone
KGO v1.4.x
Development

Successfully merging this pull request may close these issues.
2 participants
@programmer04 @pmalek