chore(ci): fix main build pipeline

.github/workflows/__build-workflow.yaml

@@ -251,6 +251,7 @@ jobs:
       - uses: actions/checkout@v4
 
       - name: Download artifact with built image
+        if: ${{ !inputs.push }}
         uses: actions/download-artifact@v4
         with:
           name: image-${{ matrix.os }}-${{ matrix.arch }}
@@ -265,9 +266,10 @@ jobs:
         uses: docker/setup-buildx-action@v3
 
       - name: Load image
-        run: |
-          docker load --input /tmp/${{ matrix.os }}/${{ matrix.arch }}/image.tar
-          docker image ls -a
+        if: ${{ !inputs.push }}
+        run: docker load --input /tmp/${{ matrix.os }}/${{ matrix.arch }}/image.tar
+
+      - run: docker image ls -a
 
       - name: Test the image by running it with -version flag
         # NOTE: we can't use steps.build.outputs.tags here because it's there's more than one tag

.github/workflows/build.yaml

@@ -14,6 +14,9 @@ on:
   push:
     branches:
     - 'main'
+  pull_request:
+    branches:
+      - '*'
   workflow_dispatch: {}
 
 jobs:
@@ -26,4 +29,6 @@ jobs:
       username: ${{ vars.DOCKERHUB_PUSH_USERNAME }}
       registry: docker.io
       image-name: ${{ vars.DOCKERHUB_IMAGE_NAME }}
-      push: true
+      # If we pushed then it means we want to build and push the image.
+      # Branch filter above will decide pushes to which branch will trigger this.
+      push: ${{ github.event.action == 'push' }}

.github/workflows/tests.yaml

@@ -125,17 +125,6 @@ jobs:
     - name: Verify that uninstalling operator CRDs via kustomize works
       run: make uninstall
 
-  build-image:
-    uses: ./.github/workflows/__build-workflow.yaml
-    secrets:
-      dockerhub-token: ${{ secrets.DOCKERHUB_PUSH_TOKEN }}
-      gh-pat: ${{ secrets.PAT_GITHUB }}
-    with:
-      username: ${{ vars.DOCKERHUB_PUSH_USERNAME }}
-      registry: docker.io
-      image-name: ${{ vars.DOCKERHUB_IMAGE_NAME }}
-      push: false
-
   build:
     runs-on: ubuntu-latest
     steps: