Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Travis Raines <[email protected]>
  • Loading branch information
pmalek and rainest authored Jun 21, 2024
1 parent 8e99018 commit 2119468
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions internal/telemetry/telemetry_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -347,8 +347,9 @@ func TestCreateManager(t *testing.T) {
// We need the custom list kinds to prevent:
// panic: coding error: you must register resource to list kind for every resource you're going
// to LIST when creating the client.
// See NewSimpleDynamicClientWithCustomListKinds or register the list into the scheme:
// gateway-operator.konghq.com/v1alpha1, Resource=aigateways out of map
// See NewSimpleDynamicClientWithCustomListKinds:
// https://pkg.go.dev/k8s.io/client-go/dynamic/fake#NewSimpleDynamicClientWithCustomListKinds
// or register the list into the scheme:
dyn := testdynclient.NewSimpleDynamicClientWithCustomListKinds(scheme,
map[schema.GroupVersionResource]string{
operatorv1alpha1.AIGatewayGVR(): "AIGatewayList",
Expand Down Expand Up @@ -486,8 +487,9 @@ func TestTelemetryUpdates(t *testing.T) {
// We need the custom list kinds to prevent:
// panic: coding error: you must register resource to list kind for every resource you're going
// to LIST when creating the client.
// See NewSimpleDynamicClientWithCustomListKinds or register the list into the scheme:
// gateway-operator.konghq.com/v1alpha1, Resource=aigateways out of map
// See NewSimpleDynamicClientWithCustomListKinds:
// https://pkg.go.dev/k8s.io/client-go/dynamic/fake#NewSimpleDynamicClientWithCustomListKinds
// or register the list into the scheme:
dyn := testdynclient.NewSimpleDynamicClientWithCustomListKinds(
scheme,
map[schema.GroupVersionResource]string{
Expand Down

0 comments on commit 2119468

Please sign in to comment.