Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: fix flaky HTTPRoute creation #16

Merged
merged 2 commits into from
Mar 18, 2024
Merged

tests: fix flaky HTTPRoute creation #16

merged 2 commits into from
Mar 18, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Mar 15, 2024

Similar to #13 but in TestGatewayMultiple.

Closes #1576

    test_gateway.go:356: 
        	Error Trace:	/home/runner/work/gateway-operator/gateway-operator/test/integration/test_gateway.go:356
        	Error:      	Received unexpected error:
        	            	admission webhook "httproutes.validation.ingress-controller.konghq.com" denied the request: Unable to validate HTTPRoute schema: making HTTP request: Post "https://10-244-15-224.dataplane-admin-1aaa01e8-ea7f-4b95-b154-975844f9ef10-xmw7qt5pqn.2ea22309-931e-4810-8638-fde098db0a27.svc:8444/schemas/routes/validate": dial tcp 10.244.15.224:8444: connect: connection refused
        	Test:       	TestIntegration/TestGatewayMultiple

@pmalek pmalek self-assigned this Mar 15, 2024
@pmalek pmalek requested a review from a team as a code owner March 15, 2024 16:27
@pmalek pmalek enabled auto-merge (squash) March 15, 2024 17:03
rainest
rainest previously requested changes Mar 15, 2024
View reviewed changes
test/integration/test_gateway.go Show resolved Hide resolved
@rainest rainest self-requested a review March 15, 2024 17:39
@rainest rainest dismissed their stale review March 15, 2024 17:40

resolved without changes

@rainest rainest removed their request for review March 15, 2024 17:40
@pmalek pmalek force-pushed the fix-flaky-httproute-creation branch from a2314d6 to b929a86 Compare March 15, 2024 18:07
@pmalek
Copy link
Member Author

pmalek commented Mar 15, 2024

actions/checkout@v4, actions/setup-go@v5, helm/[email protected], actions/upload-artifact@v3, nick-fields/retry@v3, and 2 other actions are not allowed to be used in Kong/gateway-operator. Actions in this workflow must be: within a repository owned by Kong.

Not sure what happened to CI. It seems unfixable. Let me try recreate it.

@pmalek pmalek mentioned this pull request Mar 15, 2024
Closed
@pmalek pmalek disabled auto-merge March 15, 2024 19:53
@pmalek
Copy link
Member Author

pmalek commented Mar 15, 2024

Recreation didn't help #18 🤔

@programmer04 programmer04 reopened this Mar 18, 2024
@pmalek pmalek merged commit 61735f9 into main Mar 18, 2024
13 checks passed
@pmalek pmalek deleted the fix-flaky-httproute-creation branch March 18, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainest rainest rainest left review comments

@programmer04 programmer04 programmer04 approved these changes

@mlavacca mlavacca mlavacca approved these changes

Assignees

@pmalek pmalek

Labels
area/tests test-flake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmalek @rainest @programmer04 @mlavacca