Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): update release workflow #202

Merged
merged 2 commits into from
Apr 23, 2024
Merged

chore(ci): update release workflow #202

merged 2 commits into from
Apr 23, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Apr 23, 2024 •
edited
Loading

What this PR does / why we need it:

  • add mise installation steps where it manages the tools used in workflows
  • do not set credentials to checkout KGO as private submodule (from EE): not needed anymore
    • this is needed because the workflow is reused
  • do not require build-push-images for integration tests in release pipeline (those can be run in parallel with the build stage)
  • do not set PAT_GITHUB as env when building the docker image.
    • this is needed by EE's Dockerfile

@pmalek pmalek requested a review from a team as a code owner April 23, 2024 10:27
@pmalek pmalek self-assigned this Apr 23, 2024
@pmalek pmalek added the area/ci label Apr 23, 2024
@pmalek pmalek enabled auto-merge (squash) April 23, 2024 11:10
@pmalek pmalek added this to the KGO v1.3.x milestone Apr 23, 2024
@pmalek pmalek merged commit 3f02a07 into main Apr 23, 2024
13 checks passed
@pmalek pmalek deleted the update-release-workflow branch April 23, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@programmer04 programmer04 programmer04 approved these changes

Assignees

@pmalek pmalek

Labels
area/ci
Projects
None yet
Milestone
KGO v1.3.x
Development

Successfully merging this pull request may close these issues.
2 participants
@pmalek @programmer04