fix(ci): fix release CI to work with release branches #206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This fixes the release pipeline to make it work with release branches.
Up until now the
.github/workflows/release-bot.yaml
was only triggered onmain
and.github/workflows/__release-workflow.yaml
was only creating release PRs againstmain
. That caused 1.2.2 to be released onmain
which we did not want (due to that branch already including a breaking change which we did not want to include in 1.2.x).This change makes the release workflow to accept a base branch argument so that we can release from release branches.
Ideally the
VERSION
and manifests would also get an update onmain
but that can be done separately.This also retracts the 1.2.2 tag since it was not created on a desired SHA. Deleting and re-pushing the tag does not help because golang's proxy caches modules indefinitely (https://sum.golang.org/#faq-retract-version) hence the
retract
clause added ingo.mod
.