chore(refactor): get rid of duplicated helper for TLS certs, and improve existing ones #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programmer04
force-pushed
the
consistent-certs
branch
2 times, most recently
from
9056220
to
e480f79
Compare
…ove existing ones
programmer04
force-pushed
the
consistent-certs
branch
from
e480f79
to
cb12989
Compare
programmer04
changed the title
mlavacca
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Generating a cert needed in
can be achieved without adding a new helper. This PR removes the helper introduced in #88 and uses the old one.
Moreover, it improves a little bit existing one helpers.
Which issue this PR fixes
It's a bigger initiative of dealing with certs consistently across our projects.