Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conflict updating ControlPlane's finalizers is not an error #222

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Apr 24, 2024

What this PR does / why we need it:

This PR prevents the following error when e.g. creating a Gateway:

{"level":"error","ts":"2024-04-24T09:53:30Z","msg":"Reconciler error","controller":"controlplane","controllerGroup":"gateway-operator.konghq.com","controllerKind":"ControlPlane","ControlPlane":{"name":"gw1-42khv","namespace":"default"},"namespace":"default","name":"gw1-42khv","reconcileID":"ff149a0b-f471-4671-966c-37184e4224ee","error":"failed updating ControlPlane's finalizers : Operation cannot be fulfilled on controlplanes.gateway-operator.konghq.com \"gw1-42khv\": the object has been modified; please apply your changes to the latest version and try again","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/home/runner/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/home/runner/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/home/runner/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:227"}

which is not an error which user should be aware of so just mask it and retry.

Which issue this PR fixes

Fixes #

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@pmalek pmalek self-assigned this Apr 24, 2024
@pmalek pmalek marked this pull request as ready for review April 24, 2024 20:15
@pmalek pmalek requested a review from a team as a code owner April 24, 2024 20:15
@pmalek pmalek added this to the KGO v1.3.x milestone Apr 24, 2024
Copy link
Contributor

@czeslavo czeslavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could add a note the changelog for that.

controller/controlplane/controller.go Show resolved Hide resolved
@pmalek pmalek merged commit f75ca48 into main Apr 25, 2024
13 checks passed
@pmalek pmalek deleted the conflict-updating-controlplane branch April 25, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants