Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: handle Gateway cleanup errors #248

Merged
merged 5 commits into from
May 9, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented May 8, 2024

What this PR does / why we need it:

This PR makes handling Gateway cleanup errors hide errors that users do not need to see, which in most cases will cause a requeue anyway.

For example:

Gateway.gateway.networking.k8s.io \"kong\" is invalid: metadata.finalizers: Forbidden: no new finalizers can be added if the object is being deleted, found new finalizers []string{\"gateway-operator.konghq.com/cleanup-network-policies\"}

Which issue this PR fixes

Fixes #

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@pmalek pmalek self-assigned this May 8, 2024
@pmalek pmalek marked this pull request as ready for review May 9, 2024 10:09
@pmalek pmalek requested a review from a team as a code owner May 9, 2024 10:09
@pmalek pmalek requested a review from programmer04 May 9, 2024 12:55
@pmalek pmalek enabled auto-merge (squash) May 9, 2024 12:58
@pmalek pmalek added this to the KGO v1.3.x milestone May 9, 2024
@pmalek pmalek merged commit 4b6a5f9 into main May 9, 2024
13 checks passed
@pmalek pmalek deleted the handle-gateway-cleanup-errors-gracefully branch May 9, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants