Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(conformance): enable HTTPRouteInvalidBackendRefUnknownKind #300

Merged
merged 1 commit into from
Jun 13, 2024
Merged

tests(conformance): enable HTTPRouteInvalidBackendRefUnknownKind #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: conformance-report-${{ matrix.router-flavor }}
path: kong-gateway-operator*.yaml
path: standard-*-report.yaml

integration-tests:
runs-on: ubuntu-latest
Expand Down
19 changes: 11 additions & 8 deletions test/conformance/conformance_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
"github.com/kong/gateway-operator/api/v1beta1"
gwtypes "github.com/kong/gateway-operator/internal/types"
"github.com/kong/gateway-operator/modules/manager/metadata"
"github.com/kong/gateway-operator/pkg/consts"
testutils "github.com/kong/gateway-operator/pkg/utils/test"
"github.com/kong/gateway-operator/pkg/vars"
)
Expand All @@ -29,9 +30,6 @@ var skippedTestsForExpressionsRouter = []string{
// gateway
tests.GatewayInvalidTLSConfiguration.ShortName,

// httproute
tests.HTTPRouteInvalidBackendRefUnknownKind.ShortName,

// TODO: remove the skip https://github.com/Kong/gateway-operator/issues/295
// This test is flaky.
tests.HTTPRouteWeight.ShortName,
Expand Down Expand Up @@ -130,7 +128,7 @@ func createGatewayConfiguration(ctx context.Context, t *testing.T, c Conformance
Spec: corev1.PodSpec{
Containers: []corev1.Container{
{
Name: "proxy",
Name: consts.DataPlaneProxyContainerName,
ReadinessProbe: &corev1.Probe{
InitialDelaySeconds: 1,
PeriodSeconds: 1,
Expand Down Expand Up @@ -164,7 +162,7 @@ func createGatewayConfiguration(ctx context.Context, t *testing.T, c Conformance
Spec: corev1.PodSpec{
Containers: []corev1.Container{
{
Name: "controller",
Name: consts.ControlPlaneControllerContainerName,
ReadinessProbe: &corev1.Probe{
InitialDelaySeconds: 1,
PeriodSeconds: 1,
Expand All @@ -184,10 +182,15 @@ func createGatewayConfiguration(ctx context.Context, t *testing.T, c Conformance
Name: "CONTROLLER_LOG_LEVEL",
Value: "debug",
},
{
// NOTE: we disable the admission webhook to allow broken
// resources to be created so that their status can be
// filled to satisfy conformance suite expectations.
Name: "CONTROLLER_ADMISSION_WEBHOOK_LISTEN",
Value: "off",
},
},
// TODO: https://github.com/Kong/gateway-operator/issues/294
// change nightly to 3.2 when that's released
Image: "kong/nightly-ingress-controller:2024-05-28",
Image: "kong/kubernetes-ingress-controller:3.2.0",
},
},
},
Expand Down
Loading