Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: GatewayInvalidTLSConfiguration conformance #338

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Conversation

mlavacca
Copy link
Member

What this PR does / why we need it:

Which issue this PR fixes

Fixes #54

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@mlavacca mlavacca requested a review from a team as a code owner June 17, 2024 09:14
Copy link
Contributor

@czeslavo czeslavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides a tiny nit, LGTM 👍

controller/gateway/controller_reconciler_utils.go Outdated Show resolved Hide resolved
Signed-off-by: Mattia Lavacca <[email protected]>
@mlavacca mlavacca merged commit e268b8b into main Jun 17, 2024
16 checks passed
@mlavacca mlavacca deleted the mlavacca/issue-54 branch June 17, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conformance: GatewayInvalidTLSConfiguration test
3 participants