Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix version verify script #344

Merged
merged 3 commits into from
Jun 19, 2024
Merged

chore: fix version verify script #344

merged 3 commits into from
Jun 19, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Jun 18, 2024

What this PR does / why we need it:

Verify version script didn't check the version properly in the build workflow:

Status: Downloaded newer image for kong/gateway-operator:sha-6a4d996-amd64
received version info: {
  "commit": "NOT_SET",
  "release": "NOT_SET",
  "repo": "NOT_SET"
}
false
commit doesn't match: {
  "commit": "NOT_SET",
  "release": "NOT_SET",
  "repo": "NOT_SET"
}
false
repo doesn't match: {
  "commit": "NOT_SET",
  "release": "NOT_SET",
  "repo": "NOT_SET"
}
"NOT_SET"
Version information match

https://github.com/Kong/gateway-operator-enterprise/actions/runs/9562662187/job/26359520262

This PR fixes that.

This should also catch issues like https://github.com/Kong/gateway-operator-enterprise/issues/179 in the future.

@pmalek pmalek added the area/ci label Jun 18, 2024
@pmalek pmalek self-assigned this Jun 18, 2024
@pmalek pmalek force-pushed the fix-version-verify-script branch 2 times, most recently from 77c5626 to b2c57c2 Compare June 18, 2024 15:49
@pmalek pmalek added this to the KGO v1.3.x milestone Jun 18, 2024
@pmalek pmalek force-pushed the fix-version-verify-script branch from b2c57c2 to d57cae2 Compare June 18, 2024 15:56
@pmalek pmalek force-pushed the fix-version-verify-script branch from d57cae2 to d9d906f Compare June 18, 2024 16:06
@pmalek pmalek marked this pull request as ready for review June 18, 2024 16:34
@pmalek pmalek requested a review from a team as a code owner June 18, 2024 16:35
@pmalek pmalek enabled auto-merge (squash) June 18, 2024 17:09
@pmalek pmalek merged commit e765792 into main Jun 19, 2024
16 checks passed
@pmalek pmalek deleted the fix-version-verify-script branch June 19, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants