Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set proper User-Agent for each request #387

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Conversation

programmer04
Copy link
Member

@programmer04 programmer04 commented Jun 28, 2024

What this PR does / why we need it:

Proper User-Agent header is now set on outgoing HTTP requests. An example one is
kong-gateway-operator-oss-v1.4.0. The naming pattern follows how Docker images are named where the OSS build has -oss suffix.

Which issue this PR fixes

Part of https://github.com/Kong/gateway-operator-enterprise/issues/111

Special notes for your reviewer:

Take a look at https://github.com/Kong/gateway-operator-enterprise/pull/229 which requires changes presented in this PR.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@programmer04 programmer04 force-pushed the user-agent branch 2 times, most recently from d16f487 to d08c01d Compare June 28, 2024 13:53
@programmer04 programmer04 self-assigned this Jun 28, 2024
@programmer04 programmer04 added this to the KGO v1.4.x milestone Jun 28, 2024
@programmer04 programmer04 added the enhancement New feature or request label Jun 28, 2024
@programmer04 programmer04 marked this pull request as ready for review June 28, 2024 14:12
@programmer04 programmer04 requested a review from a team as a code owner June 28, 2024 14:12
@programmer04 programmer04 enabled auto-merge (squash) June 28, 2024 14:13
@programmer04 programmer04 merged commit 0822a92 into main Jul 1, 2024
20 checks passed
@programmer04 programmer04 deleted the user-agent branch July 1, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants