fix: ensure that Gateway managed DataPlanes are reduced #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem statement
It seems that there was one step that was missed in reduction of resources, namely
Gateway
's managedDataPlane
s.When for some reason there was more than 1
DataPlane
owned by 1Gateway
at any point in time KGO never removed those:gateway-operator/controllers/gateway/controller.go
Lines 384 to 391 in 2255cec
This PR introduced the
DataPlane
reduction step which will remove the newestDataPlane
which exists when there's more than 1 of those per Gateway.Which issue does this PR solve
Fixes #29
This change has also the following effect on integration tests runtime:
Before: https://github.com/Kong/gateway-operator/actions/runs/8359101231
After: https://github.com/Kong/gateway-operator/actions/runs/8362324992?pr=43