tests: fix KongCredential tests in envtest suite #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
force-pushed
the
kongcredential-envtest
branch
3 times, most recently
from
2ec27a6
to
ef59676
Compare
pmalek
force-pushed
the
kongcredential-envtest
branch
from
ef59676
to
0800298
Compare
randmonkey
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR
envtestsuite for removal ofKongConsumercredentials removal afterKongConsumeris removed. This does not work inenvtestsuite because there is no controller that would assign the deletion timestamp to entities having owner references set after said owner (KongConsumer) is deleted.envtestsuite for APIKey credentialWhich issue this PR fixes
Fixes #
Special notes for your reviewer:
#708 tracks re-adding those tests in a different test suite.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes