-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): fix debug dockerfile and debug skaffold makefile targets #71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the clean cluster and repo is it expected to run
make skaffold
before running
make debug.skaffold
for the first time? Otherwise, it doesn't work.
Furthemore, it hangs (log from gateway-operator-controller-manager-f6c5fd8d9-xrx9x
)
2024-03-28T17:13:09Z debug layer=debugger continuing
2024-03-28T17:13:09Z debug layer=debugger ContinueOnce
2024-03-28T17:13:10.033Z - INFO - SETUP - starting controller manager - {"release": "v1.2.1-16-g366fe8c-debug", "repo": "[email protected]:Kong/gateway-operator.git", "commit": "366fe8c"}
2024-03-28T17:13:10.033Z - INFO - SETUP - development mode enabled
2024-03-28T17:13:10.033Z - INFO - SETUP - leader election disabled
2024-03-28T17:13:10.041Z - ERROR - SETUP - failed setting up controllers - {"error": "missing a required CRD: gateway.networking.k8s.io/v1, Resource=gatewayclasses"}
@programmer04 This stems from the fact that we require Gateway API CRDs when they respective controllers are enabled. gateway-operator/modules/manager/controller_setup.go Lines 102 to 155 in 3853a33
I'd prefer not to bundle these in the debug kustomization as that will become a thing that we need to maintain and secondly this would overwrite what users have in their clusters already installed. WDYT? |
Ok, seems resonable |
What this PR does / why we need it:
Fixes debug Dockerfile after changes in https://github.com/Kong/gateway-operator-archive/issues/1554
Instead of relying on third_party/ dir it hardcodes the dlv version used in the dockerfile.
We could potentially add a renovate comment to the line in the dockerfile so that the version is bumped automatically as soon as renovate is enabled on this repo.