fix(build): fix debug dockerfile and debug skaffold makefile targets

[pmalek]

What this PR does / why we need it:

Fixes debug Dockerfile after changes in https://github.com/Kong/gateway-operator-archive/issues/1554

Instead of relying on third_party/ dir it hardcodes the dlv version used in the dockerfile.

We could potentially add a renovate comment to the line in the dockerfile so that the version is bumped automatically as soon as renovate is enabled on this repo.

[programmer04]

On the clean cluster and repo is it expected to run

make skaffold

before running

make debug.skaffold

for the first time? Otherwise, it doesn't work.

Furthemore, it hangs (log from gateway-operator-controller-manager-f6c5fd8d9-xrx9x)

2024-03-28T17:13:09Z debug layer=debugger continuing
2024-03-28T17:13:09Z debug layer=debugger ContinueOnce
2024-03-28T17:13:10.033Z - INFO - SETUP - starting controller manager - {"release": "v1.2.1-16-g366fe8c-debug", "repo": "[email protected]:Kong/gateway-operator.git", "commit": "366fe8c"}
2024-03-28T17:13:10.033Z - INFO - SETUP - development mode enabled
2024-03-28T17:13:10.033Z - INFO - SETUP - leader election disabled
2024-03-28T17:13:10.041Z - ERROR - SETUP - failed setting up controllers - {"error": "missing a required CRD: gateway.networking.k8s.io/v1, Resource=gatewayclasses"}

[pmalek]

@programmer04 This stems from the fact that we require Gateway API CRDs when they respective controllers are enabled.

gateway-operator/modules/manager/controller_setup.go

Lines 102 to 155 in 3853a33

	// These checks prevent controller-runtime spamming in logs about failing
	// to get informer from cache.
	// This way we only ever check the CRD once and issue clear log entry about
	// particular CRD missing.
	// Also this makes it possible to specify more complex boolean conditions
	// whether to check for particular CRD or not, and also makes it possible to
	// specify several CRDs to be checked for existence, which are required
	// for specific controller to work.
	crdChecks := []struct {
	Condition bool
	GVRs []schema.GroupVersionResource
	}{
	{
	Condition: c.GatewayControllerEnabled || c.DataPlaneBlueGreenControllerEnabled || c.DataPlaneControllerEnabled,
	GVRs: []schema.GroupVersionResource{
	operatorv1beta1.DataPlaneGVR(),
	},
	},
	{
	Condition: c.GatewayControllerEnabled || c.ControlPlaneControllerEnabled,
	GVRs: []schema.GroupVersionResource{
	operatorv1beta1.ControlPlaneGVR(),
	},
	},
	{
	Condition: c.GatewayControllerEnabled,
	GVRs: []schema.GroupVersionResource{
	{
	Group: gatewayv1.SchemeGroupVersion.Group,
	Version: gatewayv1.SchemeGroupVersion.Version,
	Resource: "gatewayclasses",
	},
	{
	Group: gatewayv1.SchemeGroupVersion.Group,
	Version: gatewayv1.SchemeGroupVersion.Version,
	Resource: "gateways",
	},
	},
	},
	}
	checker := crdChecker{client: mgr.GetClient()}
	for _, check := range crdChecks {
	if !check.Condition {
	continue
	}
	for _, gvr := range check.GVRs {
	if ok, err := checker.CRDExists(gvr); err != nil {
	return nil, err
	} else if !ok {
	return nil, fmt.Errorf("missing a required CRD: %v", gvr)
	}
	}
	}

I'd prefer not to bundle these in the debug kustomization as that will become a thing that we need to maintain and secondly this would overwrite what users have in their clusters already installed. WDYT?

[programmer04]

Ok, seems resonable