Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor ops package #764

Merged
merged 2 commits into from
Oct 21, 2024
Merged

chore: refactor ops package #764

merged 2 commits into from
Oct 21, 2024

Conversation

mlavacca
Copy link
Member

What this PR does / why we need it:

the ops package has been refactored with the following changes:

  • all the mock files have been moved under controller/konnect/ops/mock
  • the generated mock files have been prefixed with zz_generated.
  • all the SKD interface files have been moved under controller/konnect/ops/sdk

Which issue this PR fixes

Fixes #

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@mlavacca mlavacca requested a review from a team as a code owner October 21, 2024 08:37
czeslavo
czeslavo reviewed Oct 21, 2024
View reviewed changes
Copy link
Contributor

@czeslavo czeslavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. 👍

One thing that I would maybe change is the location of mocks. As they're all SDK mocks, IMO it makes ops/sdk/mock package more suitable for them.

@mlavacca mlavacca force-pushed the rename-generated-files branch 2 times, most recently from ef57cb3 to 19ea145 Compare October 21, 2024 08:47
pmalek
pmalek reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good effort! Thanks for working on this 🙇

.mockery.yaml Show resolved Hide resolved
controller/konnect/ops/mock/sdkfactory_mock.go Outdated Show resolved Hide resolved
@mlavacca
Copy link
Member Author

Thanks for doing this. 👍

One thing that I would maybe change is the location of mocks. As they're all SDK mocks, IMO it makes ops/sdk/mock package more suitable for them.

Good point, see 63f1a70

@mlavacca mlavacca mentioned this pull request Oct 21, 2024
Open
1 task
@mlavacca mlavacca added this to the KGO v1.4.x milestone Oct 21, 2024
@pmalek
Copy link
Member

pmalek commented Oct 21, 2024

Linking #766 as related.

@pmalek pmalek merged commit 5d0b4b7 into main Oct 21, 2024
21 checks passed
@pmalek pmalek deleted the rename-generated-files branch October 21, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmalek pmalek pmalek approved these changes

@czeslavo czeslavo Awaiting requested review from czeslavo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
KGO v1.4.x
Development

Successfully merging this pull request may close these issues.
3 participants
@mlavacca @pmalek @czeslavo