-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor ops package #764
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. 👍
One thing that I would maybe change is the location of mocks. As they're all SDK mocks, IMO it makes ops/sdk/mock
package more suitable for them.
ef57cb3
to
19ea145
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good effort! Thanks for working on this 🙇
Good point, see 63f1a70 |
63f1a70
to
bc68ed7
Compare
Signed-off-by: Mattia Lavacca <[email protected]>
Signed-off-by: Mattia Lavacca <[email protected]>
028ab7a
to
66d52f1
Compare
Linking #766 as related. |
What this PR does / why we need it:
the ops package has been refactored with the following changes:
controller/konnect/ops/mock
zz_generated.
controller/konnect/ops/sdk
Which issue this PR fixes
Fixes #
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect significant changes