fix: truncate long tags in annotation #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randmonkey
force-pushed
the
fix/limit_tags_from_annotation
branch
2 times, most recently
from
50017a0
to
26f8a4f
Compare
programmer04
approved these changes
Oct 23, 2024
czeslavo
approved these changes
Oct 23, 2024
|
I added more tests to cover situations when there's too many tags in total. |
czeslavo
force-pushed
the
fix/limit_tags_from_annotation
branch
from
461fd15
to
1a8a317
Compare
czeslavo
force-pushed
the
fix/limit_tags_from_annotation
branch
from
1a8a317
to
1174be0
Compare
czeslavo
force-pushed
the
fix/limit_tags_from_annotation
branch
from
1174be0
to
877c839
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Truncate tags in annotations
konghq.com/tags.Which issue this PR fixes
Fixes #778
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes