Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): collect diagnostics in release workflow #784

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

czeslavo
Copy link
Contributor

What this PR does / why we need it:

Collect diagnostics in the reusable release workflow so we can investigate failing tests.

@czeslavo czeslavo requested a review from a team as a code owner October 23, 2024 18:06
@czeslavo czeslavo self-assigned this Oct 23, 2024
@czeslavo czeslavo added this to the KGO v1.4.x milestone Oct 23, 2024
@czeslavo czeslavo force-pushed the chore/upload-release-diagnostics branch from a020031 to ceac3ea Compare October 23, 2024 18:12
Copy link
Contributor

@randmonkey randmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was go.mod updated with no update on go code? Is it because apimachinery get bumped in this PR?

@czeslavo
Copy link
Contributor Author

czeslavo commented Oct 24, 2024

Why was go.mod updated with no update on go code? Is it because apimachinery get bumped in this PR?

It's because in the meantime (between last PR merged and now) there was an update to k8s libraries. Our updater script keeps them up-to-date and is also run in CI in the verify step. Because of that, I had to run it and commit changes to pass the verify step in CI.

@czeslavo czeslavo enabled auto-merge (squash) October 24, 2024 06:04
@czeslavo czeslavo force-pushed the chore/upload-release-diagnostics branch from ceac3ea to e101fe3 Compare October 24, 2024 08:21
@czeslavo czeslavo merged commit f124120 into main Oct 24, 2024
21 checks passed
@czeslavo czeslavo deleted the chore/upload-release-diagnostics branch October 24, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants