fix(dataplane): don't populate replicas when scaling defined #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
force-pushed
the
fix/dp-replicas-with-scaling
branch
from
165a09d
to
57529d9
Compare
czeslavo
force-pushed
the
fix/dp-replicas-with-scaling
branch
from
57529d9
to
a432afb
Compare
pmalek
approved these changes
Apr 8, 2024
pmalek
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If GatewayConfiguration specifies a non-empty deployment.scaling field in DataPlaneOptions, the Gateway controller should not populate the replicas field in DataPlane specification, even if it's nil in GatewayConfiguration.
Which issue this PR fixes
Fixes #78.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes