Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(konnect): don't block deletion when entity has no Konnect ID and is not Programmed #792

Merged

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Oct 24, 2024

What this PR does / why we need it:

Deletion of entities should not be blocked when they do not have the Konnect ID assigned and are not Programmed.

@pmalek pmalek added this to the KGO v1.4.x milestone Oct 24, 2024
@pmalek pmalek self-assigned this Oct 24, 2024
@pmalek pmalek requested a review from a team as a code owner October 24, 2024 10:48
@pmalek pmalek force-pushed the dont-block-deletion-when-not-programmed-and-no-konnect-id branch from c6e03c7 to 4642341 Compare October 24, 2024 12:17
@pmalek pmalek requested a review from czeslavo October 24, 2024 12:18
@pmalek pmalek force-pushed the dont-block-deletion-when-not-programmed-and-no-konnect-id branch from ff10d9e to e7b9553 Compare October 24, 2024 13:06
@pmalek pmalek enabled auto-merge (squash) October 24, 2024 13:06
@pmalek pmalek merged commit 924f43f into main Oct 24, 2024
21 checks passed
@pmalek pmalek deleted the dont-block-deletion-when-not-programmed-and-no-konnect-id branch October 24, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants