Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: parallel k8sio go.mod replace update script #801

Merged
merged 2 commits into from
Oct 25, 2024
Merged

chore: parallel k8sio go.mod replace update script #801

merged 2 commits into from
Oct 25, 2024

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Oct 25, 2024 •
edited
Loading

What this PR does / why we need it:

It makes the k8sio modules replace directives script concurrent to save some time.

With N=10 this gave me the following results (total time):

Cold cache Warm cache
Serial 11.982s 3.596s
Parallel 4.316s 1.365s
Diff 7.66s (~63%) 2.23s (~62%)

@czeslavo czeslavo self-assigned this Oct 25, 2024
@czeslavo czeslavo force-pushed the chore/parallel-k8s-go-mod-replace branch from 7283a2e to 05f0bd2 Compare October 25, 2024 07:43
@czeslavo czeslavo marked this pull request as ready for review October 25, 2024 07:44
@czeslavo czeslavo requested a review from a team as a code owner October 25, 2024 07:44
@czeslavo czeslavo force-pushed the chore/parallel-k8s-go-mod-replace branch from 05f0bd2 to 48651bf Compare October 25, 2024 07:46
@czeslavo czeslavo force-pushed the chore/parallel-k8s-go-mod-replace branch from 48651bf to 9cbc05e Compare October 25, 2024 07:47
@czeslavo czeslavo requested a review from pmalek October 25, 2024 08:27
pmalek
pmalek approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪄

@czeslavo czeslavo merged commit cff7520 into main Oct 25, 2024
21 checks passed
@czeslavo czeslavo deleted the chore/parallel-k8s-go-mod-replace branch October 25, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmalek pmalek pmalek approved these changes

Assignees

@czeslavo czeslavo

Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czeslavo @pmalek