Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(llm): fix nil error when identity_interface error #13676

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

t-yuki
Copy link

@t-yuki t-yuki commented Sep 14, 2024

Summary

Misconfigured ai-proxy causes unexpected nil error, instead of usual error, due to calling missing function.
It is occurred when bedrock model provider is configured without aws_region configuration.
In this PR, it's fixed by calling proper function.

Checklist

  • The Pull Request has tests
    • no test exists for bedrock configuration
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #13666

@CLAassistant
Copy link

CLAassistant commented Sep 14, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@team-eng-enablement team-eng-enablement added the author/community PRs from the open-source community (not Kong Inc) label Sep 14, 2024
@fffonion
Copy link
Contributor

Thank you! Nice catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author/community PRs from the open-source community (not Kong Inc) cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee plugins/ai-proxy plugins/ai-request-transformer plugins/ai-response-transformer size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ai-proxy nil error with bedrock misconfiguration
4 participants