feat(wasm): add wasm plugin interface #13843
Conversation
github-actions
bot
added
core/proxy
core/db
core/configuration
schema-change-noteworthy
cherry-pick kong-ee
flrgh
force-pushed
the
feat/wasm-plugins
branch
from
1359d69
to
eea3c63
Compare
kong/db/schema/init.lua
Outdated
| k = tostring(k) | ||
| local field = self.fields[k] | ||
| local subschema_field = subschema_fields[k] | ||
|
|
||
| elseif not json_schema.optional then | ||
| errors[k] = validation_errors.JSON_PARENT_KEY_MISSING:format(k, parent_key) | ||
| end | ||
| end | ||
| if field and field.type == "json" | ||
| or (subschema_field and subschema_field.type == "json") | ||
| then | ||
| errors[k] = validate_json_field(subschema_field or field, k, input) |
There was a problem hiding this comment.
The plugins entity makes use of subschemas to extend its schema/entity validation. Prior to this PR, it wasn't possible to validate json-typed fields that were members of a subschema, so that is the reason for this change.
flrgh
force-pushed
the
feat/wasm-plugins
branch
3 times, most recently
from
51b12ed
to
9e4e054
Compare
flrgh
force-pushed
the
feat/wasm-plugins
branch
from
9e4e054
to
a8fee3c
Compare
| } | ||
| end | ||
|
|
||
| for _, strategy in helpers.each_strategy({ "postgres" }) do |
There was a problem hiding this comment.
Should we have a set of tests for dbless? I'd like to see a filter being added and removed from a route/service. I think that's a case we could miss when upgrading the wasm module.
There was a problem hiding this comment.
The tests in spec/02-integration/20-wasm/09-filter-meta_spec.lua are already generic over db/dbless modes, so this round I opted to expand them to cover the route+filter plugin creation and request use case.
What do you think? Enough, or add more dbless tests? Happy to add more, but I'll need to refactor the tests in this file to some degree to separate the admin API tests (e.g. POST /plugins) from the proxy request behavioral tests.
| if t1 == "record" and t2 == "json" then | ||
| return true |
There was a problem hiding this comment.
Is this a change we must communicate to other control planes devs?
There was a problem hiding this comment.
Why is this schema file out of entities dir?
There was a problem hiding this comment.
This schema for wasm filter objects/records originally lived in kong/db/schema/entities/filter_chains.lua. To make it reusable for both kong/db/schema/entities/filter_chains.lua and kong/runloop/wasm/plugins.lua, it was factored out into its own file.
Summary
This adds a new interface to wasm filters, allowing users to configure them in the same manner as a plugin entity.
From the admin API/database/plugin entity side of things, inspiration was taken from the implementation of plugin servers, so there are parallels with regards to how filters and their schemas are discovered. Some refactoring was done so that the
filterLua schema could be reused between both thefilter_chainentity and this new plugin schema interface.This feature works in concert with the existing filter chain model. On the runloop side, we iterate over plugin entities to discover the wasm filters and create proxy-wasm filter chains on-the-fly. When an existing
filter_chainentity exists for a service/route, we append filters to it.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
KAG-5616