fix(wasm): execute filter plugins in a consistent order #13946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, execution order of filter plugins was subject to ordering returned by the underling DB implementation of `kong.db.plugins:each()`. This adds an extra step that sorts all discovered filter plugins by name so that execution order is more consistent.
github-actions
bot
added
core/proxy
cherry-pick kong-ee
kikito
approved these changes
Nov 29, 2024
ProBrian
approved these changes
Dec 2, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 2, 2024
Before this change, execution order of filter plugins was subject to ordering returned by the underling DB implementation of `kong.db.plugins:each()`. This adds an extra step that sorts all discovered filter plugins by name so that execution order is more consistent. (cherry picked from commit 0d59bd0)
|
Successfully created cherry-pick PR for |
3 tasks
|
Successfully created backport PR for |
ProBrian
pushed a commit
that referenced
this pull request
Dec 13, 2024
Before this change, execution order of filter plugins was subject to ordering returned by the underling DB implementation of `kong.db.plugins:each()`. This adds an extra step that sorts all discovered filter plugins by name so that execution order is more consistent.
lhanjian
pushed a commit
that referenced
this pull request
Dec 23, 2024
) Before this change, execution order of filter plugins was subject to ordering returned by the underling DB implementation of `kong.db.plugins:each()`. This adds an extra step that sorts all discovered filter plugins by name so that execution order is more consistent. (cherry picked from commit 0d59bd0) Co-authored-by: Michael Martin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before this change, execution order of filter plugins was subject to ordering returned by the underling DB implementation of
kong.db.plugins:each().This adds an extra step that sorts all discovered filter plugins by name so that execution order is more consistent.
Checklist
A changelog file has been createdThere is a user-facing docs PRIssue reference
KAG-5851