Pdk refine with optional cache to improvement performance #13981
Conversation
github-actions
bot
added
core/proxy
plugins/oauth2
core/pdk
plugins/cors
plugins/hmac-auth
plugins/request-transformer
plugins/aws-lambda
plugins/basic-auth
plugins/ldap-auth
plugins/grpc-web
schema-change-noteworthy
cherry-pick kong-ee
github-actions
bot
added
plugins/jwt
core/cli
core/balancer
core/clustering
core/templates
plugins/key-auth
plugins/acme
core/db
core/configuration
core/docs
core/logs
plugins/prometheus
plugins/session
chore
…tent_type replacement
ProBrian
force-pushed
the
feat/pdk-no-patching
branch
from
f5f8ba9 to
71e2a62
Compare
ProBrian
changed the title
| _G.ngx.req.read_body = function() | ||
| -- for the same request, only one `read_body` call is needed | ||
| if not ngx.ctx.body_read then | ||
| read_req_body() |
There was a problem hiding this comment.
ngx.req.read_body only need to be called once in a request lifetime. Although multiple calls in the same request
don't re-read data to buffer multiple times, there are still some extra cost of check logic. So we could just avoid it to gain better performance.
| @@ -98,7 +96,7 @@ local function new(self) | |||
| function _REQUEST.get_scheme() | |||
| check_phase(PHASES.request) | |||
|
|
|||
| return var.scheme | |||
| return ngx.ctx.scheme or var.scheme | |||
There was a problem hiding this comment.
ctx is cheaper then var, so use ctx if exists, like what we do in router handling: local req_scheme = ctx and ctx.scheme or var.scheme
| @@ -619,14 +617,14 @@ local function new(self) | |||
| -- kong.request.get_header("Host") -- "foo.com" | |||
| -- kong.request.get_header("x-custom-header") -- "bla" | |||
| -- kong.request.get_header("X-Another") -- "foo bar" | |||
| function _REQUEST.get_header(name) | |||
| function _REQUEST.get_header(name, ctx) | |||
There was a problem hiding this comment.
http_get_header supports ctx param to cache headers, expose it to get_header API so we could use cache.
| @@ -820,8 +818,7 @@ local function new(self) | |||
| -- body.age -- "42" | |||
| function _REQUEST.get_body(mimetype, max_args, max_allowed_file_size) | |||
| check_phase(before_content) | |||
|
|
|||
| local content_type = mimetype or _REQUEST.get_header(CONTENT_TYPE) | |||
| local content_type = mimetype or ngx.var.http_content_type | |||
There was a problem hiding this comment.
"Content-Type" is a built-in single value header, which means ngx.var.http_content_type always returns the same value of get_header("Content-Type"), and fetching single header by ngx.var is quicker than get_header(which may use get_headers()["Content-Type"] to get the single header).
| @@ -285,10 +285,11 @@ local function new(pdk, major_version) | |||
| -- -- or `access` phase prior calling this function. | |||
| -- | |||
| -- local body = kong.service.response.get_raw_body() | |||
| function response.get_raw_body() | |||
| function response.get_raw_body(buffered_proxying) | |||
There was a problem hiding this comment.
just a minor refinement so that if we could reduce the reads of ngx.ctx.buffered_proxying by passing it by param
| @@ -158,21 +158,22 @@ end | |||
|
|
|||
| local function do_authentication(conf) | |||
| local www_authenticate = "Basic realm=\"" .. conf.realm .. "\"" | |||
| local ctx = {} | |||
There was a problem hiding this comment.
Use a local ctx here which is cheaper thanngx.ctx, and the cache is only fresh in the local ctx lifetime, not in the request lifetime, so we don't need ngx.ctx
Summary
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]