-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sessions): store session's meatadata #13990
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
plugins/session
schema-change-noteworthy
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
labels
Dec 9, 2024
raoxiaoyan
force-pushed
the
feat/KM-788
branch
3 times, most recently
from
December 16, 2024 07:30
30ce6e0
to
7158135
Compare
sumimakito
reviewed
Dec 22, 2024
sumimakito
reviewed
Dec 22, 2024
@bungle Could you take a review for this PR, please? |
The changes in the pull request expose the controls on the |
raoxiaoyan
force-pushed
the
feat/KM-788
branch
from
December 23, 2024 03:47
7158135
to
91d9bd8
Compare
liverpool8056
requested changes
Dec 25, 2024
raoxiaoyan
force-pushed
the
feat/KM-788
branch
2 times, most recently
from
December 26, 2024 01:59
90fd87a
to
d94436f
Compare
ADD-SP
reviewed
Dec 26, 2024
raoxiaoyan
force-pushed
the
feat/KM-788
branch
2 times, most recently
from
December 27, 2024 03:07
72c0fc6
to
66572c8
Compare
outsinre
reviewed
Dec 27, 2024
If the session data is stored in the cookie, should we care about the session metadata? |
raoxiaoyan
force-pushed
the
feat/KM-788
branch
from
December 27, 2024 03:55
66572c8
to
f8bbf35
Compare
raoxiaoyan
force-pushed
the
feat/KM-788
branch
from
December 27, 2024 07:02
f8bbf35
to
c8be1a7
Compare
ADD-SP
approved these changes
Dec 30, 2024
liverpool8056
approved these changes
Dec 31, 2024
Successfully created cherry-pick PR for |
3 tasks
ADD-SP
pushed a commit
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
plugins/session
schema-change-noteworthy
size/L
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Engineering brief:
https://docs.google.com/document/d/1r7nSZGOlTVhupoVGQ6Ymqsaw64eGHKSMibko8FgrwAQ/edit?tab=t.0
### This PR won't bring a break change.
Add two new configurations
hash_subject
(by default false) andstore_metadata
(by default false). Please ref here.Add a new table
session_metadatas
to store the session's metadata.Why to do this?
Please check this PR's ticket.
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
KM-788