feat: improve caching for KTableData #2545
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Justineo
force-pushed
the
ktabledata-cache
branch
from
88c5399 to
f16a100
Compare
adamdehaven
reviewed
Jan 2, 2025
Justineo
force-pushed
the
ktabledata-cache
branch
from
f16a100 to
df6a65a
Compare
Justineo
requested review from
kongponents-bot,
jillztom,
kaiarrowood and
a team
as code owners
Justineo
commented
Jan 22, 2025
| isValidating: ref(false), | ||
| mutate: () => ({}), | ||
| }) | ||
|
|
There was a problem hiding this comment.
useSWRV should always be a function. Are there any known scenarios where we might consider taking the other branch? @adamdehaven
There was a problem hiding this comment.
TBH I'm not sure why this code was in place
There was a problem hiding this comment.
The only thing that comes to mind is whether this was added specifically for some testing purposes. I suggest removing it to check if any test cases fail.
Preview package from this PR in consuming applicationIn consuming application project install preview version of kongponents generated by this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
swrvbeta (withisLoadingsupport).<KTableData>