Skip to content

Commit

Permalink
chore: remove unused KongClient's ingressClass field (#5039)
Browse files Browse the repository at this point in the history
  • Loading branch information
pmalek authored Oct 31, 2023
1 parent e4ff0f4 commit cc4d68a
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 10 deletions.
7 changes: 0 additions & 7 deletions internal/dataplane/kong_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,6 @@ type KongConfigBuilder interface {
type KongClient struct {
logger logr.Logger

// ingressClass indicates the Kubernetes ingress class that should be
// used to qualify support for any given Kubernetes object to be parsed
// into data-plane configuration.
ingressClass string

// requestTimeout is the maximum amount of time that should be waited for
// requests to the data-plane to receive a response.
requestTimeout time.Duration
Expand Down Expand Up @@ -152,7 +147,6 @@ type KongClient struct {
func NewKongClient(
logger logr.Logger,
timeout time.Duration,
ingressClass string,
diagnostic util.ConfigDumpDiagnostic,
kongConfig sendconfig.Config,
eventRecorder record.EventRecorder,
Expand All @@ -166,7 +160,6 @@ func NewKongClient(
) (*KongClient, error) {
c := &KongClient{
logger: logger,
ingressClass: ingressClass,
requestTimeout: timeout,
diagnostic: diagnostic,
prometheusMetrics: metrics.NewCtrlFuncMetrics(),
Expand Down
2 changes: 0 additions & 2 deletions internal/dataplane/kong_client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -667,7 +667,6 @@ func setupTestKongClient(
) *KongClient {
logger := zapr.NewLogger(zap.NewNop())
timeout := time.Second
ingressClass := "kong"
diagnostic := util.ConfigDumpDiagnostic{}
config := sendconfig.Config{}
dbMode := "off"
Expand All @@ -679,7 +678,6 @@ func setupTestKongClient(
kongClient, err := NewKongClient(
logger,
timeout,
ingressClass,
diagnostic,
config,
eventRecorder,
Expand Down
1 change: 0 additions & 1 deletion internal/manager/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,6 @@ func Run(
dataplaneClient, err := dataplane.NewKongClient(
logger,
time.Duration(c.ProxyTimeoutSeconds*float32(time.Second)),
c.IngressClassName,
diagnostic,
kongConfig,
eventRecorder,
Expand Down

0 comments on commit cc4d68a

Please sign in to comment.