Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gateway_discovery) enable gateway discovery in db mode #4828

Merged
merged 14 commits into from
Nov 2, 2023

Update internal/clients/manager.go

56a71a4
Select commit
Loading
Failed to load commit list.
Merged

feat(gateway_discovery) enable gateway discovery in db mode #4828

Update internal/clients/manager.go
56a71a4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 2, 2023 in 1s

75.5% (-0.1%) compared to c44cb7b

View this Pull Request on Codecov

75.5% (-0.1%) compared to c44cb7b

Details

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (c44cb7b) 75.5% compared to head (56a71a4) 75.5%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4828     +/-   ##
=======================================
- Coverage   75.5%   75.5%   -0.1%     
=======================================
  Files        167     167             
  Lines      18881   18903     +22     
=======================================
+ Hits       14273   14278      +5     
- Misses      3783    3795     +12     
- Partials     825     830      +5     
Files Coverage Δ
internal/manager/config_validation.go 82.1% <ø> (-1.6%) ⬇️
internal/manager/run.go 55.5% <100.0%> (+0.6%) ⬆️
internal/util/dataplane/mode.go 100.0% <100.0%> (ø)
internal/clients/manager.go 96.2% <80.0%> (-1.5%) ⬇️
internal/dataplane/kong_client.go 86.0% <78.9%> (-3.5%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.