tests: fix TestKongRouterFlavorCompatibility e2e test and make it test all Kong Gateway flavors
#4988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6656417014 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4988 +/- ##
=======================================
- Coverage 77.6% 75.3% -2.4%
=======================================
Files 167 167
Lines 18709 18709
=======================================
- Hits 14527 14094 -433
- Misses 3345 3789 +444
+ Partials 837 826 -11 ☔ View full report in Codecov by Sentry. |
pmalek
force-pushed
the
e2e-testflavor-test-make-it-work-with-all-router-flavors
branch
from
35abe36
to
ba67786
Compare
|
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6657351292 |
pmalek
changed the title
TestKongRouterFlavorCompatibility e2e test and make it test all Kong Gateway flavors
…t all Kong Gateway flavors
pmalek
force-pushed
the
e2e-testflavor-test-make-it-work-with-all-router-flavors
branch
from
ba67786
to
fc4c8e4
Compare
|
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6664894139 |
czeslavo
approved these changes
Oct 27, 2023
pmalek
deleted the
e2e-testflavor-test-make-it-work-with-all-router-flavors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Noticed during debugging e2e test failures from #4934
MakeThis was already done as part of #4934. This PR here adds deployment of echo backends (which were not added in #4934) to allow test to pass.TestKongRouterFlavorCompatibilityrun tests for all 3 router flavors.Previous scaffolding didn't allow to addThis was already done as part of #4934expressionsbecause when a rolling upgrade is performed KIC is not able to transition from 1 router flavor into another.This also adds cleanup of resources deployed in each subtest so that they can each deploy their own without conflicts.
This will fix failures as in https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6654763042/job/18083851340