-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: fix TestKongRouterFlavorCompatibility
e2e test and make it test all Kong Gateway flavors
#4988
tests: fix TestKongRouterFlavorCompatibility
e2e test and make it test all Kong Gateway flavors
#4988
Conversation
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6656417014 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4988 +/- ##
=======================================
- Coverage 77.6% 75.3% -2.4%
=======================================
Files 167 167
Lines 18709 18709
=======================================
- Hits 14527 14094 -433
- Misses 3345 3789 +444
+ Partials 837 826 -11 ☔ View full report in Codecov by Sentry. |
35abe36
to
ba67786
Compare
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6657351292 |
TestKongRouterFlavorCompatibility
e2e test and make it test all Kong Gateway flavors
…t all Kong Gateway flavors
ba67786
to
fc4c8e4
Compare
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6664894139 |
What this PR does / why we need it:
Noticed during debugging e2e test failures from #4934
MakeThis was already done as part of #4934. This PR here adds deployment of echo backends (which were not added in #4934) to allow test to pass.TestKongRouterFlavorCompatibility
run tests for all 3 router flavors.Previous scaffolding didn't allow to addThis was already done as part of #4934expressions
because when a rolling upgrade is performed KIC is not able to transition from 1 router flavor into another.This also adds cleanup of resources deployed in each subtest so that they can each deploy their own without conflicts.
This will fix failures as in https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6654763042/job/18083851340