tests: fix TestDeployAndUpgradeAllInOneDBLESS tests by using traditional router in upgrade tests
#4997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nal router in upgrade tests
|
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6667346628 |
pmalek
changed the title
TestDeployAndUpgradeAllInOneDBLESS tests by using traditional router in upgrade tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4997 +/- ##
=====================================
Coverage 75.3% 75.4%
=====================================
Files 167 167
Lines 18714 18714
=====================================
+ Hits 14110 14118 +8
+ Misses 3778 3773 -5
+ Partials 826 823 -3 ☔ View full report in Codecov by Sentry. |
programmer04
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR changes the target router flavor in
TestDeployAndUpgradeAllInOneDBLESStotraditionalto keep the upgrade use the same router flavor in deployed Kong Gateway as the base and target of the upgrade.Related issue which aims to use
helmin e2e tests: #4973Which issue this PR fixes:
Special notes for your reviewer: