Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use only 46 bits for priorities of generated Kong routes #5010

Closed
wants to merge 2 commits into from

Conversation

randmonkey
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes:

fixes #5009

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@randmonkey randmonkey requested a review from a team as a code owner October 30, 2023 09:28
@randmonkey randmonkey added area/kong Issue with Kong proxy behavior, rather than the controller ci/run-e2e Trigger e2e test run from PR and removed size/L labels Oct 30, 2023
@randmonkey randmonkey marked this pull request as draft October 30, 2023 09:29
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6690809874

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (256ce95) 72.9% compared to head (2d53e9c) 73.0%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5010   +/-   ##
=====================================
  Coverage   72.9%   73.0%           
=====================================
  Files        167     167           
  Lines      18719   18718    -1     
=====================================
+ Hits       13654   13666   +12     
+ Misses      4233    4223   -10     
+ Partials     832     829    -3     
Files Coverage Δ
internal/dataplane/parser/translators/atc_utils.go 100.0% <ø> (ø)
...rnal/dataplane/parser/translators/grpcroute_atc.go 93.6% <94.1%> (-0.1%) ⬇️
...rnal/dataplane/parser/translators/httproute_atc.go 90.8% <95.4%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -56,7 +56,7 @@ require (
k8s.io/client-go v0.28.3
k8s.io/component-base v0.28.3
sigs.k8s.io/controller-runtime v0.16.3
sigs.k8s.io/gateway-api v1.0.0-rc2
sigs.k8s.io/gateway-api v1.0.0-rc2.0.20231027061746-5fd8bec3bedc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not bump this in a PR not related to Gateway API

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out to the branch from another branch to update the conformance tests. I will make another PR from main branch and close this.

@randmonkey randmonkey closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kong Issue with Kong proxy behavior, rather than the controller
Projects
None yet
3 participants