-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove "password" input in kong/license step of workflows #5316
Conversation
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/7162394343 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5316 +/- ##
=======================================
- Coverage 75.9% 75.8% -0.1%
=======================================
Files 170 170
Lines 19447 19447
=======================================
- Hits 14767 14751 -16
- Misses 3851 3864 +13
- Partials 829 832 +3 ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/2.12.x release/2.12.x
# Navigate to the new working tree
cd .worktrees/backport-release/2.12.x
# Create a new branch
git switch --create backport-5316-to-release/2.12.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 77527ee81e175e5a0860c0f1a29c09df1c6388f3
# Push it to GitHub
git push --set-upstream origin backport-5316-to-release/2.12.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/2.12.x Then, create a pull request where the |
(cherry picked from commit 77527ee)
(cherry picked from commit 77527ee)
* chore(gha): preemptively add 1p creds (cherry picked from commit e84786e) * chore: remove "password" input in kong/license step of workflows (#5316) (cherry picked from commit 77527ee) --------- Co-authored-by: Isa Farnik <[email protected]> Co-authored-by: Tao Yi <[email protected]>
…5414) * fix(manager) restore InitCacheSyncDuration (#5238) Fix regression that removed initial cache sync delay. Add --init-cache-sync-duration flag to override the delay period. --------- Co-authored-by: Travis Raines <[email protected]> (cherry picked from commit 1737253) * chore(gha): preemptively add 1p creds * chore: remove "password" input in kong/license step of workflows (#5316) --------- Co-authored-by: Jonah Back <[email protected]> Co-authored-by: Isa Farnik <[email protected]> Co-authored-by: Tao Yi <[email protected]>
What this PR does / why we need it:
Upstream action
Kong/kong-license
has deprecated the inputpassword
and produces warnings if it is present. We should remove the input in calling the action.Which issue this PR fixes:
--
Special notes for your reviewer:
May need to be backported to
2.12.x
because we need run tests against KIC 2.12 LTS on this branch.PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR