Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): use mise to manage third party tools #5751

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Mar 26, 2024

What this PR does / why we need it:

This PR adapts Kong/gateway-operator#17 to KIC's repo to manage dependencies using mise.

This leaves out several tools that still require the third_party's go.mod because there are no plugins for mise in https://github.com/mise-plugins/registry for those tools and I didn't want to wait too long with this change.

If anyone would like to create a plugin for any of those:

  • looppointer
  • staticcheck
  • or dlv

I'm happy to help. Here's an example what that looks like: https://github.com/pmalek/mise-setup-envtest/.


Also adds renovate annotations to .tools_version.yaml and a corresponding config section.

Tested on fork: pmalek#22.

@pmalek pmalek added area/ci dependencies Pull requests that update a dependency file labels Mar 26, 2024
@pmalek pmalek self-assigned this Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.4%. Comparing base (b7afb20) to head (a6511bd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5751     +/-   ##
=======================================
+ Coverage   71.8%   73.4%   +1.6%     
=======================================
  Files        175     175             
  Lines      18147   18147             
=======================================
+ Hits       13037   13332    +295     
+ Misses      4165    3843    -322     
- Partials     945     972     +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek pmalek force-pushed the third-party-using-mise branch 8 times, most recently from d211164 to 18b8d1b Compare March 26, 2024 14:41
@pmalek pmalek marked this pull request as ready for review March 26, 2024 15:14
@pmalek pmalek requested a review from a team as a code owner March 26, 2024 15:14
@programmer04
Copy link
Member

I think that Go 1.22 will enable by default remediation, so it will make looppointer obsolete. So it's not a big deal, we can even enable this with env var now

@pmalek pmalek merged commit 713765d into main Mar 28, 2024
38 checks passed
@pmalek pmalek deleted the third-party-using-mise branch March 28, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci dependencies Pull requests that update a dependency file size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants