Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify tools installation and management with mise #6564

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

programmer04
Copy link
Member

@programmer04 programmer04 commented Oct 24, 2024

What this PR does / why we need it:

πŸ™‡ Please test locally on your machine.

❗ There is a problem with Checks / linters / lint (pull_request_target), because we use workflow from main branch and it uses third_party/go.mod that is removed in this file, so it has to be merged with by-passing and observing on main

Scope

  • Get rid of dir third_party and dedicated go.mod for managing tooling and all related Makefile config. Use mise to install delve from the source code (a binary is not provided).
  • gotestsum is handled natively
  • crd-ref-docs use the same approach for installation as for delve - built from source
  • setup-envtest is handled natively
  • staticcheck is handled natively
  • cleanup leftovers from already removed (see chore(ci): disable exportloopref, loopvar and enable copyloopvar linterΒ #6563) deprecated looppointer linter.

Which issue this PR fixes:

Follow up for #6563

@programmer04 programmer04 added dependencies Pull requests that update a dependency file area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. labels Oct 24, 2024
@programmer04 programmer04 self-assigned this Oct 24, 2024
@programmer04 programmer04 requested a review from a team as a code owner October 24, 2024 21:01
@programmer04 programmer04 enabled auto-merge (squash) October 24, 2024 21:03
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 73.7%. Comparing base (35b1374) to head (056aae6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #6564     +/-   ##
=======================================
+ Coverage   69.5%   73.7%   +4.2%     
=======================================
  Files        202     202             
  Lines      25796   25796             
=======================================
+ Hits       17935   19024   +1089     
+ Misses      6853    5750   -1103     
- Partials    1008    1022     +14     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Contributor

@czeslavo czeslavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the experimental setting to the .mise.toml config file so we don't have to set it manually:

[settings]
experimental = true

@programmer04 programmer04 force-pushed the rm-third_party branch 2 times, most recently from 0f29a23 to 879190b Compare October 25, 2024 09:54
@programmer04 programmer04 marked this pull request as draft October 25, 2024 09:55
auto-merge was automatically disabled October 25, 2024 09:55

Pull request was converted to draft

@programmer04 programmer04 force-pushed the rm-third_party branch 2 times, most recently from 07537b1 to 058630f Compare October 25, 2024 12:10
@programmer04 programmer04 changed the title chore: get rid of third_party dir for managing tool versions chore: simplify tools installation and management with mise Oct 25, 2024
@programmer04 programmer04 force-pushed the rm-third_party branch 2 times, most recently from 0628226 to acf6726 Compare October 25, 2024 12:28
@programmer04 programmer04 marked this pull request as ready for review October 25, 2024 12:28
@programmer04
Copy link
Member Author

I implemented your suggestion @czeslavo and made couple of other improvements, so please check everything again

Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, worked on my machine πŸŽ‰

Copy link
Contributor

@czeslavo czeslavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸš€

@programmer04 programmer04 merged commit 652af99 into main Oct 25, 2024
39 of 41 checks passed
@programmer04 programmer04 deleted the rm-third_party branch October 25, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. dependencies Pull requests that update a dependency file size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants