-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: refactor Gateway API's route parent status update code #6877
Conversation
7d65d00
to
a4da1d7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6877 +/- ##
=======================================
+ Coverage 76.5% 76.8% +0.2%
=======================================
Files 212 214 +2
Lines 25246 25139 -107
=======================================
- Hits 19321 19308 -13
+ Misses 4912 4814 -98
- Partials 1013 1017 +4 ☔ View full report in Codecov by Sentry. |
a4da1d7
to
74daebb
Compare
74daebb
to
c9a2c4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM, some minor comments.
03d3322
to
d09588c
Compare
d09588c
to
fea7a4c
Compare
What this PR does / why we need it:
Refactor route parent status handling for Gateway API routes. This extract code from
ensureGatewayReferenceStatusAdded
from all the route controllers and adds common functions based on implementationensureGatewayReferenceStatusAdded
intointernal/controllers/gateway/route_parent_status.go
.Which issue this PR fixes:
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR