feat: geo map component #1430
Merged
feat: geo map component #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipgutica
force-pushed
the
feat/geo-map-component
branch
2 times, most recently
from
6a483c7 to
b89acf3
Compare
filipgutica
force-pushed
the
feat/geo-map-component
branch
from
b89acf3 to
fdfd140
Compare
filipgutica
force-pushed
the
feat/geo-map-component
branch
from
8a13ca4 to
0622d24
Compare
filipgutica
force-pushed
the
feat/geo-map-component
branch
from
efd54d2 to
4403e7e
Compare
filipgutica
force-pushed
the
feat/geo-map-component
branch
from
4403e7e to
1bf3821
Compare
adamdehaven
reviewed
Jul 3, 2024
packages/analytics/analytics-geo-map/src/components/AnalyticsGeoMap.vue
Outdated
Show resolved
Hide resolved
packages/analytics/analytics-geo-map/src/components/AnalyticsGeoMap.vue
Outdated
Show resolved
Hide resolved
packages/analytics/analytics-geo-map/src/components/AnalyticsGeoMap.vue
Outdated
Show resolved
Hide resolved
packages/analytics/analytics-geo-map/src/components/AnalyticsGeoMap.vue
Outdated
Show resolved
Hide resolved
packages/analytics/analytics-geo-map/src/components/AnalyticsGeoMap.vue
Outdated
Show resolved
Hide resolved
mihai-peteu
reviewed
Jul 3, 2024
packages/analytics/analytics-geo-map/src/components/AnalyticsGeoMap.vue
Outdated
Show resolved
Hide resolved
| const { ISO_A2, ADMIN } = feature.properties | ||
| const metric = props.countryMetrics[ISO_A2] | ||
| if (metric !== undefined) { | ||
| popup.setLngLat(e.lngLat).setHTML(`<strong>${ADMIN}</strong>: ${metric} ${props.metricUnit}`).addTo(map.value as Map) |
There was a problem hiding this comment.
non-blocking, just a thought. Since setHTML doesn't sanitize, hoping we can create a custom plugin here like we did for ChartJS.
There was a problem hiding this comment.
non-blocking, just a thought. Since
setHTMLdoesn't sanitize, hoping we can create a custom plugin here like we did for ChartJS.
This is maplibre's setHTML fn: https://maplibre.org/maplibre-gl-js/docs/API/classes/Popup/#sethtml
We can iterate on this. values templated into the html (metric and metricUnit) are well typed and validated, so for simplicity, we can just use maplibre's api for displaying a popup until we need something more "custom"
mihai-peteu
reviewed
Jul 8, 2024
mihai-peteu
previously approved these changes
Jul 8, 2024
mihai-peteu
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://konghq.atlassian.net/browse/MA-2941
Resources