feat(entities): config store secret #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumimakito
reviewed
Sep 9, 2024
sumimakito
reviewed
Sep 9, 2024
Comment on lines
+405
to
+416
| const deleteAssociatedConfigStore = async (configStoreId: string): Promise<void> => { | ||
| const { apiBaseUrl, app, controlPlaneId } = (props.config as KonnectVaultListConfig) | ||
| const url = `${apiBaseUrl}${endpoints.list[app].deleteConfigStore}` | ||
| .replace(/{controlPlaneId}/gi, controlPlaneId || '') | ||
| .replace(/{id}/gi, configStoreId) | ||
| try { | ||
| await axiosInstance.delete(url) | ||
| } catch (error: any) { | ||
| // There is a rare case where more than 1 vaults are linked to the config store (i.e. created via API). | ||
| // In this case, the deletion will fail but the UI can safely ignore the error. | ||
| } | ||
| } |
There was a problem hiding this comment.
qq: Would we delete the associated config store if a user tries to delete a Konnect vault from the vault detail page as well?
There was a problem hiding this comment.
Yes I think we should. I'll add this logic in the host app.
sumimakito
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Integrate Konnect Vault with Konnect Config Store
KM-445
Resources