Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(expressions): update completion provider #1887

Merged
merged 1 commit into from
Jan 10, 2025
Merged

fix(expressions): update completion provider #1887

merged 1 commit into from
Jan 10, 2025

Conversation

Leopoldthecoder
Copy link
Member

@Leopoldthecoder Leopoldthecoder commented Jan 10, 2025 •
edited
Loading

Summary

Now you can type a non-root-level property to see all completion items that contain the property.

Before After
Kapture 2025-01-10 at 14 40 39 Kapture 2025-01-10 at 14 39 05

@Leopoldthecoder Leopoldthecoder marked this pull request as ready for review January 10, 2025 07:03
@Leopoldthecoder Leopoldthecoder requested a review from a team as a code owner January 10, 2025 07:03
sumimakito
sumimakito approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@sumimakito sumimakito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested and LGTM

@Leopoldthecoder Leopoldthecoder merged commit b0c93de into main Jan 10, 2025
11 checks passed
@Leopoldthecoder Leopoldthecoder deleted the fix/update-completion branch January 10, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumimakito sumimakito sumimakito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leopoldthecoder @sumimakito