Add possibility to check flavoured android modules #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxtracking
reviewed
Jun 14, 2023
| @@ -64,4 +64,10 @@ open class ApiValidationExtension { | |||
| * By default, only the `main` source set is checked. | |||
| */ | |||
| public var additionalSourceSets: MutableSet<String> = HashSet() | |||
|
|
|||
| /** | |||
| * In Android projects with multiple flavour, | |||
maxtracking
reviewed
Jun 14, 2023
| * Copyright 2016-2022 JetBrains s.r.o. | ||
| * Use of this source code is governed by the Apache 2.0 License that can be found in the LICENSE.txt file. | ||
| */ | ||
| import org.jetbrains.kotlin.gradle.plugin.* |
There was a problem hiding this comment.
nitpick: Should it follow the same rules as in other changed files for explicit imports? Or vice versa?
|
@qwwdfsad Is it possible to prioritise this PR? |
|
Does this take into account that some modules inside the project might lack flavors or the particular flavor set here?(when the plugin is configured in the root gradle file) My suggestion would be to generate unique tasks for each flavor, similar to other gradle plugins compatible with flavors. |
|
Fair, I don't think I have checked that, let's try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the option to test flavoured android modules thanks to
testedFlavourNameparameterit would solve #24