Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vertica DB support on dataframe-jdbc #604

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

brunoteo
Copy link

Hi!
I've created this pull request to handle Vertica Database inside dataframe-jdbc

A new Vertica.kt class was added that implements DbType

I tested the solution in verticaTest.kt class running this local docker image -> https://hub.docker.com/r/vertica/vertica-ce

The documentation is updated with the Vertica dependency

Thanks

@zaleslaw zaleslaw self-requested a review February 27, 2024 12:51
@zaleslaw
Copy link
Collaborator

Hi @brunoteo thanks for the contribution! We need approximately 2–4 weeks to test your solution and make a decision about including this feature in 0.14 release or not. After that, I will be able to return to you with some questions.

It's an excellent-prepared PR!

@zaleslaw zaleslaw added the enhancement New feature or request label Feb 27, 2024
@zaleslaw zaleslaw added this to the 0.14.0 milestone Feb 27, 2024
@Jolanrensen Jolanrensen added the good first issue Good issues to pick-up for newcomers label Feb 27, 2024
@zaleslaw zaleslaw removed the good first issue Good issues to pick-up for newcomers label Feb 27, 2024
@zaleslaw zaleslaw added the databases JDBC related issues label Sep 3, 2024
@zaleslaw zaleslaw removed this from the 0.14.0 milestone Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
databases JDBC related issues enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants