[Compiler plugin] Lower frontend generated implicit receivers #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koperagen
added
the
Compiler plugin
|
Generated sources will be updated after merging this PR. |
Jolanrensen
reviewed
Sep 18, 2024
| @@ -11,6 +12,7 @@ import org.jetbrains.kotlinx.dataframe.impl.columnName | |||
| import kotlin.reflect.KProperty | |||
| import kotlin.reflect.typeOf | |||
|
|
|||
| @HasSchema(schemaArg = 0) | |||
There was a problem hiding this comment.
What does HasSchema do again? There's no docs :/
Jolanrensen
reviewed
Sep 18, 2024
| fun box(): String { | ||
| val df = List(10) { Record(it.toString(), it) }.let { dataFrameOf(*it.toTypedArray()) } | ||
| val aggregate = df.pivot { b }.aggregate { | ||
| this.add("c") { 123 }.c |
There was a problem hiding this comment.
which part failed before and is now solved?
Jolanrensen
reviewed
Sep 18, 2024
| @OptIn(UnsafeDuringIrConstructionAPI::class) | ||
| private fun IrExpression.replaceWithConstructorCall(): IrConstructorCallImpl { | ||
| val constructor = type.getClass()!!.constructors.toList().single() | ||
| val type = type |
There was a problem hiding this comment.
unnecessary assignment
Jolanrensen
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For extension properties to work, frontend plugin inserts implicit receivers. But they are just non-existing references needed for resolve. Backend must find them and replace with something that will be executed