Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render FormattedFrame stored inside columns as HTML #944

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

koperagen
Copy link
Collaborator

With this change it will be possible to format structured data:
image

df.groupBy { receiverType }.toDataFrame("api")
    .convert { api }
    .with { it.format { all() }.where { refine || interpretable }.with { background(green) } }

@koperagen koperagen added the enhancement New feature or request label Nov 7, 2024
@koperagen koperagen added this to the 0.15.0 milestone Nov 7, 2024
@koperagen koperagen self-assigned this Nov 7, 2024
@Jolanrensen
Copy link
Collaborator

Jolanrensen commented Nov 11, 2024

So, now you can have different configurations for each different nested DataFrame? That's cool :)

@ermolenkodev Did you ever get to supporting formatting in Notebook tables? If so, you'd probably also need to take this into account.

@koperagen
Copy link
Collaborator Author

koperagen commented Nov 11, 2024

So, now you can have different configurations for each different nested DataFrame? That's cool :)

Yes. For example, i wanted to have green background for all dataframe API that are annotated with refine or interpretable. Later i decided that it will be more convenient (for those looking at the table) to groupBy this dataframe by receiver type and have the same formatting. But i couldn't do it anymore, without this change

Copy link
Collaborator

@Jolanrensen Jolanrensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :) looks good!

@koperagen koperagen merged commit 125def0 into master Nov 12, 2024
6 checks passed
@Jolanrensen Jolanrensen deleted the html-rendering-improvements branch November 12, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants