Skip to content

Commit

Permalink
remove todos
Browse files Browse the repository at this point in the history
  • Loading branch information
whyoleg committed Oct 20, 2023
1 parent 02fcac2 commit f39f5a4
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 38 deletions.
23 changes: 0 additions & 23 deletions dokka-subprojects/analysis-kotlin-descriptors/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -21,26 +21,3 @@ dependencies {
implementation(projects.analysisKotlinDescriptorsCompiler)
implementation(projects.analysisKotlinDescriptorsIde)
}

// TODO [structure-refactoring] move to `publishing-shadow`
//tasks {
// // There are several reasons for shadowing all dependencies in one place:
// // 1. Some of the artifacts Dokka depends on, like com.jetbrains.intellij.java:java-psi, are not
// // published to Maven Central, so the users would need to add custom repositories to their build scripts.
// // 2. There are many intertwining transitive dependencies of different versions, as well as direct copy-paste,
// // that can lead to runtime errors due to classpath conflicts, so it's best to let Gradle take care of
// // dependency resolution, and then pack everything into a single jar in a single place that can be tuned.
// // 3. The compiler and ide modules are internal details that are likely to change, so packing everything into
// // a single jar provides some stability for the CLI users, while not exposing too many internals. Publishing
// // the compiler, ide and other subprojects separately would make it difficult to refactor the project structure.
// shadowJar {
// // cannot be named exactly like the artifact (i.e analysis-kotlin-descriptors-VER.jar),
// // otherwise leads to obscure test failures when run via CLI, but not via IJ
// archiveFileName.set("analysis-kotlin-descriptors-all-${project.version}.jar")
// archiveClassifier.set("")
//
// // service files are merged to make sure all Dokka plugins
// // from the dependencies are loaded, and not just a single one.
// mergeServiceFiles()
// }
//}
14 changes: 0 additions & 14 deletions dokka-subprojects/analysis-kotlin-symbols/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -80,17 +80,3 @@ dependencies {
// TODO [beresnev] get rid of it
compileOnly(libs.kotlinx.coroutines.core)
}

// TODO [structure-refactoring] move to `publishing-shadow`
//tasks {
// shadowJar {
// // cannot be named exactly like the artifact (i.e analysis-kotlin-symbols-VER.jar),
// // otherwise leads to obscure test failures when run via CLI, but not via IJ
// archiveFileName.set("analysis-kotlin-symbols-all-${project.version}.jar")
// archiveClassifier.set("")
//
// // service files are merged to make sure all Dokka plugins
// // from the dependencies are loaded, and not just a single one.
// mergeServiceFiles()
// }
//}
1 change: 0 additions & 1 deletion dokka-subprojects/core/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ plugins {
id("org.jetbrains.conventions.publishing-default")
}

// TODO [structure-refactoring] may be it's not needed, as we have same project name
overridePublicationArtifactId("dokka-core")

dependencies {
Expand Down

0 comments on commit f39f5a4

Please sign in to comment.