Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kotlin compiler and KGP to 1.9.20-RC2 #3262

Merged
merged 7 commits into from
Nov 1, 2023

Conversation

vmishenev
Copy link
Contributor

The current changes are related to JetBrains/kotlin@d797505

@vmishenev vmishenev linked an issue Oct 25, 2023 that may be closed by this pull request
@vmishenev vmishenev force-pushed the vmishenev/3248-update-kotlin-to-1.9.20-RC2 branch from 14f45c6 to 878a890 Compare October 25, 2023 19:36
@vmishenev vmishenev self-assigned this Oct 25, 2023
@vmishenev vmishenev changed the title Update Kotlin compiler to 1.9.20-RC2 Update Kotlin compiler and KGP to 1.9.20-RC2 Oct 26, 2023
@vmishenev vmishenev marked this pull request as ready for review October 26, 2023 11:40
@IgnatBeresnev
Copy link
Member

The current changes are related to JetBrains/kotlin@d797505

Do you know if this has any user-visible effect? That is, can its removal lead to some bugs, inconsistencies or some other problems in the generated documentation/signatures?

@vmishenev
Copy link
Contributor Author

Do you know if this has any user-visible effect? That is, can its removal lead to some bugs, inconsistencies or some other problems in the generated documentation/signatures?

According to KT-59643 it disables merging a forward declaration with an actual declaration. It is how the compiler works now. I am unsure it changes the view of signatures.

Copy link
Member

@IgnatBeresnev IgnatBeresnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update TestedVersions just in case? (remembered about it just now)

@vmishenev vmishenev force-pushed the vmishenev/3248-update-kotlin-to-1.9.20-RC2 branch from 5d1732d to 66b7697 Compare October 27, 2023 01:09
@vmishenev vmishenev force-pushed the vmishenev/3248-update-kotlin-to-1.9.20-RC2 branch from 66b7697 to bba9690 Compare October 27, 2023 10:46
@IgnatBeresnev IgnatBeresnev self-requested a review October 30, 2023 18:24
@vmishenev vmishenev merged commit 2b0a63f into master Nov 1, 2023
10 checks passed
@vmishenev vmishenev deleted the vmishenev/3248-update-kotlin-to-1.9.20-RC2 branch November 1, 2023 16:46
@@ -1,6 +1,6 @@
[versions]

gradlePlugin-kotlin = "1.9.10"
gradlePlugin-kotlin = "1.9.20-RC2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kotlin 1.9.20 is released already :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Kotlin & compiler to 1.9.20-RC2
3 participants