Fix enum test, add toolchains and running on JDK 21 #3376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Started thorough workflow on CI: https://github.com/Kotlin/dokka/actions/runs/6984087458 |
IgnatBeresnev
approved these changes
Nov 27, 2023
vmishenev
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging PR #3349 to master, enum test failed on JDK 17: https://github.com/Kotlin/dokka/actions/runs/6983352619/job/19004323879#step:6:362
Cause: in JDK 12 one new method was added to Enum class - https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/lang/Enum.html#describeConstable()
Also checked on JDK 21 - one more failure, now because of deprecation for removal of finalize in JDK 18 - https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/lang/Enum.html#finalize()
Added running tests for JDK 21 on CI + gradle toolchain auto-resolve - https://docs.gradle.org/current/userguide/toolchains.html#sub:download_repositories - it's hard to extract it into version catalog as it's applied in settings.gradle.kts....