[K2] Fix typealiased type that leads to functional type #3396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyoleg
approved these changes
Dec 4, 2023
IgnatBeresnev
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Could you please also do something with the unsafe list index access in KotlinSignatureProvider#486? It's from the exception in the reported issue. I don't think it should fail the build even if something wasn't resolved properly by analysis.
It could generate nothing inside parentheses and emit a warning, it could write Error class in its place (if it should've been resolved, but there's nothing there), or maybe you'll come up with some other solution
I have added a simple check on it since we have no constraints on a number of arguments in a functional type. |
vmishenev
added a commit
that referenced
this pull request
Mar 20, 2024
* [K2] Fix typealiased type to function * Add check on emptiness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.